Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api.onedrive.com to webaudio default whitelist #72

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Add api.onedrive.com to webaudio default whitelist #72

merged 3 commits into from
Aug 6, 2024

Conversation

yingKatsu
Copy link
Contributor

Another way to have direct links to onedrive content that pac users often use.

Example link:
https://api.onedrive.com/v1.0/shares/u!aHR0cHM6Ly8xZHJ2Lm1zL3UvcyFBcmFSdWJSdXY0SlM5azRMN3F4T1R6YkNYRkd0P2U9a093U3Az/root/content

Pac3 documentation containing a convenient converter for onedrive indirect links to api.onedrive.com direct links:
https://wiki.pac3.info/tutorial/hosting

@yogwoggf
Copy link

yogwoggf commented Aug 6, 2024

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

@yingKatsu
Copy link
Contributor Author

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

Thank you for your consideration; I was aware that he had left Garry's Mod but while doing this same pr to Starfall and looking into webaudio I noticed that they had recently commented a day ago on a wiremod pr so I thought that maybe there was a chance. Would you happen to know anyone with write access that I could ping, or is webaudio now actively maintained by someone else under a different repo?

@yogwoggf
Copy link

yogwoggf commented Aug 6, 2024

Courtesy note: @Vurv78 is no longer actively maintaining webaudio so you may want to ping/ask someone with write access to the repository for this PR to get merged

Thank you for your consideration; I was aware that he had left Garry's Mod but while doing this same pr to Starfall and looking into webaudio I noticed that they had recently commented a day ago on a wiremod pr so I thought that maybe there was a chance. Would you happen to know anyone with write access that I could ping, or is webaudio now actively maintained by someone else under a different repo?

Makes sense, I just saw the review comment you were talking about. Anyways, I'm not totally sure, but potentially @StyledStrike could have write access?

@Vurv78 Vurv78 merged commit 14a2832 into Vurv78:main Aug 6, 2024
1 check passed
@Vurv78
Copy link
Owner

Vurv78 commented Aug 6, 2024

I will not do anything that involves me ingame or takes a ton of time, but if people want to make PRs to my repos I will briefly review and merge if it's fine.

@StyledStrike
Copy link
Contributor

Makes sense, I just saw the review comment you were talking about. Anyways, I'm not totally sure, but potentially @StyledStrike could have write access?

oh I did only two small pull requests here, I'm not a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants